Fetch settings values from sdk and use language code - #3484
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
please update owncloud-sdk and add some error handling |
|
Added message on error |
kulmann
changed the title
| @@ -0,0 +1,7 @@ | |||
| Change: Make settings available in phoenix | |||
There was a problem hiding this comment.
"Enhancement" might be better in this case?
There was a problem hiding this comment.
Nope, it's a change. ;-) Introduces settings to phoenix => entirely new feature.
There was a problem hiding this comment.
Exactly, a new feature which doesn't change any existing functionality
| logout(context) { | ||
| const logoutFinalizer = () => { | ||
| context.dispatch('cleanUpLoginState') | ||
| context.dispatch('loadSettingsValues') |
There was a problem hiding this comment.
Why load the settings during logout?
There was a problem hiding this comment.
Because there will be settings that exist without user context. For example, when we provide multiple themes in the future, an admin could set a default theme in settings. That has to be available even if you don't have a user context. So as a result, all changes to the authenticated user (changing to another one or signing out) need to trigger a settings reload.
There was a problem hiding this comment.
I see. I am just a bit afraid of relying on authentication in this case because of the public link's context.
LukasHirt
left a comment
LukasHirt
left a comment
There was a problem hiding this comment.
Looks great! Settings is amazing progress 🚀
3 participants
This PR depends on owncloud/owncloud-sdk#475, so this has to stay WIP until the SDK-PR is merged and released.
Description
We have a settings service, that is supposed to be integrated in Phoenix like described in the docs
This PR uses settings values, coming from the settings service, to adapt the Phoenix UI for the authenticated user. At the moment, only the
languagesetting is used: Changing the language in the settings frontend (has to be configured as a Phoenix app) results in having another language in Phoenix. In the future we can make use of this for a variety of customization:Related Issue
owncloud/product#17
Motivation and Context
We want to provide a customized user experience for users.
How Has This Been Tested?
So far only in Chrome and Firefox. No tests implemented so far.
Screenshots (if appropriate):
English UI
Changed language to French
French UI (at least everything that's translated already)
Types of changes
Checklist:
Open tasks: