Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

Fix share indicators click to open the correct panel - #3420

Merged
PVince81 merged 1 commit into
masterfrom
fix-share-indicator-click
Apr 30, 2020
Merged

Fix share indicators click to open the correct panel#3420
PVince81 merged 1 commit into
masterfrom
fix-share-indicator-click

Conversation

@PVince81

Copy link
Copy Markdown
Contributor

Description

When clicking on a share indicator inside a file list row, the correct share panel will now be displayed.

Related Issue

Fixes #3324

Motivation and Context

How Has This Been Tested?

Manual test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

When clicking on a share indicator inside a file list row, the correct share panel will now be displayed.
@LukasHirt

Copy link
Copy Markdown
Collaborator

@PVince81 Would it make sense to cover this with tests? To prevent the same error again in the future?

@PVince81

Copy link
Copy Markdown
Contributor Author

@LukasHirt I started with it and was wondering how to formulate the test.
In general we don't want to talk about clicks, but more about "the user opens the panel" or even not mention any UI elements. Since this is a shortcut, not sure.

@individual-it any thoughts ?

@LukasHirt

Copy link
Copy Markdown
Collaborator

I started with it and was wondering how to formulate the test.
In general we don't want to talk about clicks, but more about "the user opens the panel" or even not mention any UI elements. Since this is a shortcut, not sure.

I guess we might try something like "the user opens the collaborators panel via its indicator". But yeah, I know what you mean. If you want we can also merge this and discuss/implement the tests separately. Not to block this bugfix. Your call 😉

@PVince81
PVince81 merged commit a671417 into master Apr 30, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the fix-share-indicator-click branch April 30, 2020 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Click on public link share indicator is broken

2 participants