This repository was archived by the owner on Jul 14, 2026. It is now read-only.
Display indirect shares for links - #2932
Merged
Merged
Conversation
5 tasks
PVince81
force-pushed
the
share-indirect-outgoing-links
branch
2 times, most recently
from
January 29, 2020 16:43
62f785d to
b4f290f
Compare
Contributor
Author
|
The feature works now and the tests pass. However the styling isn't looking good, we have the "via" link alignment problem here as well. |
Public link shares from parent resources are now shown in the public link share panel with a "via" link to jump to the parent resource.
PVince81
force-pushed
the
share-indirect-outgoing-links
branch
from
January 29, 2020 19:30
b4f290f to
390b149
Compare
Contributor
Author
|
@kulmann apart from the styling I think the PR would be ready, CI has passed last time and I've just rebased. Please review the current code. If you have time, can you take care of adjusting the styling like you did for collaborators, maybe with the table ? |
kulmann
approved these changes
Jan 30, 2020
kulmann
left a comment
kulmann
left a comment
Contributor
There was a problem hiding this comment.
Changed some minor issues myself
- added a commit for proper list item styling when having via-links
- moved list items in a separate component to avoid code duplication
duplication and fix styling of indirect link shares.
kulmann
force-pushed
the
share-indirect-outgoing-links
branch
from
January 30, 2020 11:45
f854fc9 to
fc55d87
Compare
Contributor
|
|
Intention is to make copy to clipboard, which is visible for direct and indirect link shares, the rightmost button, so that the alignment is correct.
After refactoring the file list item into PublicLinkListItem, the method formDateFromNow was not accessible any more as it was present in the mixin from the original component. This fix adds the mixing to PublicLinkListItem to make that function work again and fixes the issue where links that have an expiration date set would not be shown.
Contributor
Author
11 tasks
Contributor
Author
|
last commits from @kulmann are ok 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Display indirect link shares in the links panel when link shares exist on any parent resource.
Related Issue
Fixes #2897
(the PR is based on top of the two PRs)
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: