Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

Fix token refresh flow - #2472

Merged
DeepDiver1975 merged 1 commit into
masterfrom
bugfix/token-refresh
Nov 18, 2019
Merged

Fix token refresh flow#2472
DeepDiver1975 merged 1 commit into
masterfrom
bugfix/token-refresh

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Nov 15, 2019

Copy link
Copy Markdown
Member

Description

  • rename login button to login
  • drop oidcSilentRedirect.vue
  • by default try to refresh the auth token - missing piece from some previous refactor

How Has This Been Tested?

  • setup phoenix with a true openid connect provider (e.g. kopano konnectd)
  • wait for token expiry (life time depends on IdP)
  • see in console that the token is refreshed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Nov 15, 2019
@DeepDiver1975 DeepDiver1975 self-assigned this Nov 15, 2019
@LukasHirt LukasHirt added Status:Needs-release and removed Status:Needs-Review Needs review from a maintainer labels Nov 15, 2019
@DeepDiver1975
DeepDiver1975 merged commit 8d234b5 into master Nov 18, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the bugfix/token-refresh branch November 18, 2019 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants