This repository was archived by the owner on Jul 14, 2026. It is now read-only.
switched to sessionStorage - #2416
Merged
DeepDiver1975 merged 3 commits intoNov 14, 2019
Merged
Conversation
Collaborator
|
We also store user + capabilities in the local storage via vuex store. I think that will need to be adjusted as well. |
Collaborator
|
IMO looks good. Still would prefer to see @DeepDiver1975 opinion here though before approving. |
Contributor
💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6317/
|
DeepDiver1975
approved these changes
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switched the storage of the auth service from local to session storage.
Related Issue
Motivation and Context
If the browser will be closed and therefore the session ends the user should start a new auth flow.
Open tasks: