Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

Change key of file action buttons to ariaLabel - #2219

Merged
PVince81 merged 1 commit into
masterfrom
bugfix/actions-keys
Oct 14, 2019
Merged

Change key of file action buttons to ariaLabel#2219
PVince81 merged 1 commit into
masterfrom
bugfix/actions-keys

Conversation

@LukasHirt

Copy link
Copy Markdown
Collaborator

Motivation and Context

Using index as a key can cause troubles with rendering of elements.

How Has This Been Tested?

  • test environment: Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer Type:Technical-Debt labels Oct 11, 2019
@LukasHirt LukasHirt self-assigned this Oct 11, 2019

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
PVince81 merged commit 3f3b9bc into master Oct 14, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the bugfix/actions-keys branch October 14, 2019 06:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Status:Needs-Review Needs review from a maintainer Type:Technical-Debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants