This repository was archived by the owner on Jul 14, 2026. It is now read-only.
Use PQueue to run only one create folder promise in folder upload - #2210
Merged
Conversation
Member
|
In case the nested folder structure holds files with the same name there is a warning i the browser console.
|
Member
|
I did not properly see if this has an impact on the upload list - but given the warning and code location I suspect that the list will not properly be populated |
Use unique id for item key
LukasHirt
force-pushed
the
bugfix/folder-upload-queue
branch
from
October 10, 2019 14:51
8dbadff to
22673e4
Compare
Collaborator
Author
|
@DeepDiver1975 Added unique id and used it as a key. Error is gone now 😉 |
DeepDiver1975
approved these changes
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use PQueue to run only one create folder promise in folder upload so that parent folder can be created before the children.
How Has This Been Tested?
Types of changes
Checklist: