Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

Set X-Requested-With header - required ownCloud 10.3 - #1984

Merged
LukasHirt merged 1 commit into
masterfrom
bugfix/set-X-Requested-With
Sep 16, 2019
Merged

Set X-Requested-With header - required ownCloud 10.3#1984
LukasHirt merged 1 commit into
masterfrom
bugfix/set-X-Requested-With

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Sep 16, 2019

Copy link
Copy Markdown
Member

Description

Any request sent from phoenix to ownCloud has to include the header X-Requested-With
This is necessary to prevent browsers to popup an authentication dialog on a 401 response

This will only work with ownCloud 10.3

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 self-assigned this Sep 16, 2019
@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Sep 16, 2019
@PVince81

Copy link
Copy Markdown
Contributor

Restarted CI jobs. Somehow some were marked cancelled.

@LukasHirt

Copy link
Copy Markdown
Collaborator

Restarted CI jobs. Somehow some were marked cancelled.

Failing also in some other places. Going over the "1 hour" limit for tasks...

@LukasHirt
LukasHirt merged commit 188b041 into master Sep 16, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the bugfix/set-X-Requested-With branch September 16, 2019 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Status:Needs-Review Needs review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants