docs: remove documentation for archived apps#1555
Merged
Merged
Conversation
phil-davis
approved these changes
Jul 1, 2026
Contributor
|
Q, without having that checked manually, are the impersonate and sharepoint apps removed from the image already? The text above does not mention this. |
The impersonate and sharepoint apps have been archived and are no longer maintained. Remove their dedicated pages, navigation entries, supported-apps listings, and the prose references recommending their installation. Historical release notes are left untouched. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
df59b51 to
8d19cbb
Compare
DeepDiver1975
commented
Jul 1, 2026
DeepDiver1975
left a comment
Member
Author
There was a problem hiding this comment.
LGTM overall — clean removal, no dangling xrefs, both apps verified archived (owncloud/impersonate and owncloud/sharepoint, isArchived: true).
Verified against PR head:
- No remaining
xref:/nav reference to any of the 3 deleted pages (impersonate_users.adoc,sharepoint-integration_configuration.adoc,sharepoint_connecting.adoc) → Antora build won't break. - Supported-apps list, both nav files, general-topics index, and
_config_commands.adoccross-ref all cleaned. Rewordedfiles_lifecycle.adocTIP andmigrating_to_kiteworks.adocpassages read cleanly (no dangling list markers, grammar intact). - Remaining "sharepoint" mentions are unrelated (prose in
classic_ui/.../sharing.adoc, external MS-docs URLs) — correctly left alone.
Nit (non-blocking, no build impact):
- Orphaned image dirs left behind — their only consumers were the deleted pages:
modules/admin_manual/images/apps/impersonate/(6 PNGs)modules/admin_manual/images/enterprise/external_storage/sharepoint/(4 PNGs)
No.adocreferences them anymore. Antora ignores unused images so the build is fine; delete them in this PR for completeness or leave for a follow-up.
changelog=n-a (docs repo has no changelog).
🤖 Generated with Claude Code
Contributor
|
I will take care on orphaned images. There is an easy process for that. A extension I have written needs to be enabled for this and prints orphaned files that can post reviewing be removed. Done, will be fixed with the upcoming additional changes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The impersonate and sharepoint apps have been archived for security reasons and are no longer maintained. This removes their documentation footprint:
configuration/general_topics/impersonate_users.adoc,enterprise/external_storage/sharepoint-integration_configuration.adoc,classic_ui/external_storage/sharepoint_connecting.adoc.Historical release notes are intentionally left untouched. The
updateranddirect_menuapps have no dedicated documentation. Generic/unrelated "impersonate" references (audit-log events, oCIS auth-app impersonation, security prose) are preserved.