Skip to content

Propagator: Pump in more requests if we think current ones are quick - #4529

Merged
guruz merged 1 commit into
masterfrom
dynamic_parallelism_scaling
Mar 2, 2016
Merged

Propagator: Pump in more requests if we think current ones are quick#4529
guruz merged 1 commit into
masterfrom
dynamic_parallelism_scaling

Conversation

@guruz

@guruz guruz commented Mar 1, 2016

Copy link
Copy Markdown
Contributor

Helps with small file sync #331
When I benchmarked this, it went up to 6 parallelism and
was about 1/3 faster than the previous fixed 3 parallelism.
Doing more than 6 is dangerous because QNAM limits to 6 TCP
connections and also the server might become a bottleneck.

Should also help for #4081

@guruz guruz added this to the 2.2.0-current milestone Mar 1, 2016
Comment thread src/libsync/owncloudpropagator.cpp Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: this-> is unnecessary here and above

@ckamm

ckamm commented Mar 2, 2016

Copy link
Copy Markdown
Contributor

Looks good, only minor comments!

Helps with small file sync #331
When I benchmarked this, it went up to 6 parallelism and
was about 1/3 faster than the previous fixed 3 parallelism.
Doing more than 6 is dangerous because QNAM limits to 6 TCP
connections and also the server might become a bottleneck.

Should also help for #4081
@guruz
guruz force-pushed the dynamic_parallelism_scaling branch from 4256f18 to d78c367 Compare March 2, 2016 14:22
guruz added a commit that referenced this pull request Mar 2, 2016
Propagator: Pump in more requests if we think current ones are quick
@guruz
guruz merged commit 266508b into master Mar 2, 2016
@guruz

guruz commented Mar 2, 2016

Copy link
Copy Markdown
Contributor Author

@ckamm Thanks, merged with your recommended changes

@rienesl

rienesl commented Mar 2, 2016

Copy link
Copy Markdown

Yes, of course, it would speed up for small files, but there are still timeout problems when using parallelism with big files on slow connections, so it would be really nice, if you could let decide the user, how much parallelism he want's (dropdownbox?)!

@dragotin

dragotin commented Mar 3, 2016

Copy link
Copy Markdown
Contributor

I think we need some specific QA for this, @guruz what do you think? Could you add some hints how to test and compare that to the state before to the test instructions in the wiki?

@ogoffart
ogoffart deleted the dynamic_parallelism_scaling branch April 21, 2016 14:10
@davidpablomitchell

Copy link
Copy Markdown

hello team, where and how i and change parallelism or any manner to use all my bandwidth???? thank you

@guruz

guruz commented May 20, 2016

Copy link
Copy Markdown
Contributor Author

@davidpablomitchell hi! it should already use all your bandwidth. Did you accidently activate the bandwidth limit in the settings?
What are your symptoms?
Which OS? What do you upload/download?

@davidpablomitchell

Copy link
Copy Markdown

when i have lot of files i see the bandwidth is not all o have

@davidpablomitchell

Copy link
Copy Markdown

Hello sorry i download a bug file 1.5TB from server to client and my connection don't pass 30mb how can i use my line of 300mb with other type of software i can use 300mb downloading.
thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants