Skip to content

🌱 move from golang/mock to uber/gomock - #4645

Merged
spencerschrock merged 2 commits into
ossf:mainfrom
tylerauerbeck:update-gomock
Jun 6, 2025
Merged

🌱 move from golang/mock to uber/gomock#4645
spencerschrock merged 2 commits into
ossf:mainfrom
tylerauerbeck:update-gomock

Conversation

@tylerauerbeck

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

This moves from the deprecated golang/mock package to the fork hosted by uber

What is the current behavior?

Currently uses github.com/golang/mock/gomock for mocking. This switches to utilize the supported fork at go.uber.org/mock/gomock.

What is the new behavior (if this is a feature change)?**

No change in behavior. Mocking works as it does today.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #4451

Special notes for your reviewer

There are existing failing lints which appear to be addressed in a handful of recent PR's.

Does this PR introduce a user-facing change?

N/A

NONE

Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
@tylerauerbeck
tylerauerbeck requested a review from a team as a code owner June 1, 2025 16:36
@tylerauerbeck
tylerauerbeck requested review from raghavkaul and spencerschrock and removed request for a team June 1, 2025 16:36

@spencerschrock spencerschrock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Only one small question

Comment thread tools/go.mod Outdated
@codecov

codecov Bot commented Jun 2, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.29%. Comparing base (353ed60) to head (adde65a).
Report is 176 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4645      +/-   ##
==========================================
+ Coverage   66.80%   68.29%   +1.48%     
==========================================
  Files         230      249      +19     
  Lines       16602    18884    +2282     
==========================================
+ Hits        11091    12896    +1805     
- Misses       4808     5129     +321     
- Partials      703      859     +156     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
@spencerschrock
spencerschrock enabled auto-merge (squash) June 6, 2025 17:01
@spencerschrock
spencerschrock merged commit e29967d into ossf:main Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

switch off deprecated dependencies

2 participants