🌱 move from golang/mock to uber/gomock - #4645
Merged
Merged
Conversation
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
tylerauerbeck
requested review from
raghavkaul and
spencerschrock
and removed request for
a team
June 1, 2025 16:36
tylerauerbeck
temporarily deployed
to
integration-test
June 2, 2025 14:39 — with
GitHub Actions
Inactive
spencerschrock
approved these changes
Jun 2, 2025
spencerschrock
left a comment
Member
There was a problem hiding this comment.
Thank you! Only one small question
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4645 +/- ##
==========================================
+ Coverage 66.80% 68.29% +1.48%
==========================================
Files 230 249 +19
Lines 16602 18884 +2282
==========================================
+ Hits 11091 12896 +1805
- Misses 4808 5129 +321
- Partials 703 859 +156 🚀 New features to boost your workflow:
|
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
tylerauerbeck
temporarily deployed
to
integration-test
June 6, 2025 16:59 — with
GitHub Actions
Inactive
spencerschrock
enabled auto-merge (squash)
June 6, 2025 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This moves from the deprecated golang/mock package to the fork hosted by uber
What is the current behavior?
Currently uses
github.com/golang/mock/gomockfor mocking. This switches to utilize the supported fork atgo.uber.org/mock/gomock.What is the new behavior (if this is a feature change)?**
No change in behavior. Mocking works as it does today.
Which issue(s) this PR fixes
Fixes #4451
Special notes for your reviewer
There are existing failing lints which appear to be addressed in a handful of recent PR's.
Does this PR introduce a user-facing change?
N/A