[#695] PresentationShared의 HomeTab 전용 코드 소유권을 정리한다#699
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 HomeTab 모듈 내의 여러 뷰와 피처(WebItemRow, SearchFeature, SearchView, RecentTodoItem)의 접근 제어자를 public에서 내부(internal) 수준으로 변경하고 테스트 설정을 업데이트합니다. 리뷰에서는 ComposableArchitecture 및 OrderedCollections 등 파일 내에서 직접 사용하는 외부 의존성 라이브러리의 임포트가 누락되거나 제거된 점을 지적하며, 암시적 임포트에 의존하지 않고 명시적으로 임포트하도록 개선을 제안했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
PresentationShared에 남아 있던 Home 전용 검색, 웹 페이지, 최근 Todo 표현 코드의 소유권을HomeTab으로 정리📝 작업 내용
📌 요약
HomeTabtarget으로 이동HomeTabtarget으로 이동HomeTabTests로 이동🔍 상세
SearchFeature,SearchView를PresentationShared/Sources/Search에서HomeTab/Sources/Home/Search로 이동RecentTodoItem,WebPageItem,WebItemRow를HomeTab/Sources/Home하위로 이동SearchFeatureTests,SearchFeatureTestDoubles를PresentationSharedTests에서HomeTabTests로 이동SearchFeature,SearchView,RecentTodoItem,WebItemRow의public접근 제어 제거Entry의 Home navigation에서 사용하는HomeRoute,WebPageItempublic 표면 유지📸 영상 / 이미지 (Optional)