[#696] Presentation과 Entry target 책임을 분리한다#698
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 Presentation 타겟을 리팩터링하여 root, auth, tab shell 흐름을 담당하는 Entry 타겟과 공통 UI를 담당하는 PresentationShared 타겟으로 분리하고, 기존 Presentation 타겟은 이들을 re-export하도록 구조를 개선했습니다. 이에 따라 프로젝트 설정 및 관련 문서가 업데이트되었습니다. 피드백으로는 EntryTestSupport.swift 내 SignInUseCaseSpy 클래스가 비동기 환경에서 가변 상태를 안전하게 다룰 수 있도록 @MainActor 격리를 추가할 것을 제안합니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🔗 연관된 이슈
🎯 의도
Presentationtarget이 root/auth/main/window 흐름과 shared UI를 함께 소유하던 구조 정리Presentation은App의 기존 import를 유지하기 위한 re-export target으로 축소하고, 앱 진입 UI 흐름은Entry, 공통 Todo/Search/Loading 흐름은PresentationShared, 각 탭 흐름은 tab target이 소유하도록 책임을 분리📝 작업 내용
📌 요약
Entrytarget 추가Entry로 이동Presentationtarget을Entry,PresentationSharedre-export 역할로 축소PresentationTests를EntryTests,PresentationSharedTests기준으로 분리🔍 상세
RootFeature,RootView,LoginFeature,LoginView,MainFeature,MainView,MainTab, window coordinator를Entrytarget 하위로 이동Entry가 root/auth/main/window 흐름에 필요한Domain참조를 직접 소유하도록 정리Presentationtarget의 직접Domain의존성을 제거하고EntryExports.swift만 남김LoadingState를 실제 사용처 기준으로PresentationShared로 이동PresentationSharedTests와EntryTests를 분리하고 각 target별 SwiftLint 설정 추가.github/workflows/ci.yml의Presentation테스트 경로를 신규 test scheme 기준으로 갱신README.md, architecture harness 문서,docs/graph.png를 현재 target 구조에 맞게 갱신📸 영상 / 이미지 (Optional)
없음