[#675] Notification 탭을 NotificationTab 모듈로 분리한다#693
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 알림 기능 관련 코드를 별도의 NotificationTab 및 NotificationTabTests 타겟으로 분리하여 모듈화를 진행하고, 이에 맞춰 필요한 클래스와 구조체, 익스텐션의 접근 제어자를 public으로 수정하였습니다. 또한 MainView에서 NotificationTab을 임포트하고 코디네이터의 selectedTodoId 프로퍼티를 직접 사용하도록 개선했습니다. 리뷰 의견으로는 PushNotificationQuery+Presentation.swift 파일 내의 익스텐션들에 대해 개별 멤버마다 public 키워드를 붙이는 대신, 익스텐션 자체를 public extension으로 선언하여 코드를 더 간결하게 작성할 것을 제안합니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
DevLogPresentation에서 분리해NotificationTab모듈이 화면, feature, coordinator, 테스트를 소유하도록 정리📝 작업 내용
📌 요약
NotificationTab,NotificationTabTeststarget 추가NotificationTab으로 이동NotificationTabTests로 이동Presentation의MainView가NotificationTabpublic entry를 사용하도록 정리🔍 상세
Application/Presentation/Project.swift에NotificationTab,NotificationTabTeststarget 추가PushNotificationItem,PushNotificationQuery+Presentation을NotificationTab소유로 이동PushNotificationListFeature,PushNotificationListView,PushNotificationListViewCoordinator, dependency key를NotificationTab으로 이동PushNotificationListView,PushNotificationListViewCoordinator만 public entry로 공개MainView는NotificationTab을 import하고, coordinator의selectedTodoIdfacade를 통해 detail 영역 구성@testable import를NotificationTab기준으로 변경NotificationTab이Presentation,HomeTab,TodayTab을 import하지 않도록 의존 방향 유지📸 영상 / 이미지 (Optional)
docs/graph.png갱신