Skip to content

Fixed XStreamAlias for ignore_attribute #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janvanrijn merged 3 commits into from
Mar 19, 2021
Merged

Fixed XStreamAlias for ignore_attribute #45

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13b0dcd
Fixed XStreamAlias for ignore_attribute
mwever Mar 17, 2021
ca296f1
Added junit test for checking that ignore attribute is not empty for
mwever Mar 17, 2021
5761733
Merge pull request #48 from openml/develop
janvanrijn Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apiconnector/src/main/java/org/openml/apiconnector/xml/DataSetDescription.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public class DataSetDescription extends OpenmlApiResponse {
@XStreamAlias("oml:row_id_attribute")
private String row_id_attribute;

@XStreamImplicit(itemFieldName = "ignore_attribute")
@XStreamImplicit(itemFieldName = "oml:ignore_attribute")

@janvanrijn janvanrijn Mar 17, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind also extending a unit test (e.g., one that downloads a dataset with ignore attribute from the test set, and checks whether it is not empty)?

Thanks!

private String[] ignore_attribute;

@XStreamAlias("oml:version_label")
Expand Down