fix: align inline search inputs & a11y#2775
Merged
Merged
Conversation
Visually align inline search inputs to look the same across the page and add type="search" to be a11y compliant.
JammingBen
commented
Jun 30, 2026
| classes.push(...['leading-7', 'h-8']) | ||
| } else { | ||
| classes.push('h-10') | ||
| classes.push('h-9') |
Member
Author
There was a problem hiding this comment.
h-9 to match the appearance of our other input fields.
kulmann
reviewed
Jul 1, 2026
| v-model="filterTerm" | ||
| class="mr-2 mt-4" | ||
| :label="$gettext('Filter members')" | ||
| :placeholder="$gettext('Search for members')" |
Member
There was a problem hiding this comment.
The placeholder doesn't seem to appear 🤔
Member
There was a problem hiding this comment.
I was in the wrong Search for members, was looking at space members 😆 sorry for the noise
kulmann
approved these changes
Jul 2, 2026
openclouders
pushed a commit
that referenced
this pull request
Jul 2, 2026
fix: align inline search inputs & a11y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visually align inline search inputs to look the same across the page (and with other, regular input fields) and add
type="search"to be a11y compliant.