Skip to content

feat(antivirus): add partial scanning mode#559

Merged
v-scharf merged 1 commit into
opencloud-eu:mainfrom
fschade:antivirus-truncate-mode
Apr 7, 2025
Merged

feat(antivirus): add partial scanning mode#559
v-scharf merged 1 commit into
opencloud-eu:mainfrom
fschade:antivirus-truncate-mode

Conversation

@fschade

@fschade fschade commented Apr 2, 2025

Copy link
Copy Markdown
Member

Description

This pull request introduces a partial mode for antivirus scanning to handle large files efficiently.

Related Issue

Dependencies

This pull request depends on the following PR being merged first:

Motivation and Context

This change is required to enhance the antivirus scanning efficiency for large files. The partial mode allows handling large files by scanning parts rather than loading the entire file.

Screenshots (if appropriate):

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Code changes
  • Unit tests added
  • Documentation added

@fschade fschade force-pushed the antivirus-truncate-mode branch from 4af773b to 84855a0 Compare April 3, 2025 15:53
@fschade fschade changed the title feat(antivirus): add truncate mode support feat(antivirus): add partial scanning mode Apr 4, 2025
@micbar

micbar commented Apr 4, 2025

Copy link
Copy Markdown
Member

Reva is merged and released.

@fschade fschade force-pushed the antivirus-truncate-mode branch 2 times, most recently from 3873a9e to 054fd32 Compare April 7, 2025 14:33
@fschade fschade marked this pull request as ready for review April 7, 2025 14:33

@aduffeck aduffeck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sane to me, but I'm a bit confused between the meaning of MaxScanSize, MaxFileSize and StreamMaxLength and would like to actually try this out before we ship this change.

@fschade fschade marked this pull request as draft April 7, 2025 14:49
@fschade

fschade commented Apr 7, 2025

Copy link
Copy Markdown
Member Author

detailed description can be found here: https://github.com/Cisco-Talos/clamav/blob/main/etc/clamd.conf.sample
I will re-try it tomorrow and try to write a more meaningful description for those.

@micbar we've decided not to include this feature in today's rolling release until we have a better description.

I'll do the backports afterwards.

- Introduced partial mode for antivirus scanning to handle large files efficiently.
- Introduced clamAV scan timeout
@fschade fschade force-pushed the antivirus-truncate-mode branch from 054fd32 to bd1fc8a Compare April 7, 2025 15:09
@fschade fschade marked this pull request as ready for review April 7, 2025 15:23
@v-scharf v-scharf merged commit 5410cae into opencloud-eu:main Apr 7, 2025
@openclouders openclouders mentioned this pull request Apr 7, 2025
1 task
@v-scharf v-scharf mentioned this pull request Apr 10, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants