With #1191 we're getting one step closer to being able to remove the need to client side created signed urls.
Problem
- The
signing-key endpoint is the last remaining endpoint offered by the ocs service in OpenCloud (not to be confused with the ocs service in reva). Removing it would mean we could delete the whole service
- The concept of client side signed urls has a few drawbacks
- The secret used for signing the url leaks the server
- The client is able to generate any signed url it likes
- The client is in control of the lifetime of the signature
- per-user secrets need to be managed and stored on the server side
Solution
Switch all remaining cases where signed urls are needed to be able to download things to use server generated signed urls. Currently client signed urls are used by web at least in these cases:
The other clients (desktop, ios, android) don't seem to be using the signing-key anywhere.
With #1191 we're getting one step closer to being able to remove the need to client side created signed urls.
Problem
signing-keyendpoint is the last remaining endpoint offered by theocsservice in OpenCloud (not to be confused with theocsservice in reva). Removing it would mean we could delete the whole serviceSolution
Switch all remaining cases where signed urls are needed to be able to download things to use server generated signed urls. Currently client signed urls are used by web at least in these cases:
/cloud/user/signing-keyendpoint #1197 (comment)The other clients (desktop, ios, android) don't seem to be using the
signing-keyanywhere.