chore: add missing appstream metainfo

[p-fruck]

Continues the work of #1011 (comment)

Questions of @TheOneRing:

Where are the branding colours coming from?

I used the header color from here:

desktop/src/libsync/opencloudtheme.cpp

Line 31 in 5656a4b

return QColor("#20434F");

for the Windows store we got an age rating 0+ if that is in any way relevant for the oars part

Honestly I don't know, I just used the oars website and chose "Application that can connect to the internet", which I suspect is true here (even though we only connect to some opencloud instance and don't support webbrowsing etc). Do you suggest some other rating?

I would also like to get an approval from @CodedOre here before merging so we can continue on flathub/flathub#9623.

As the app id is defined via cmake, I would propose to change the name to opencloud.metainfo.xml as well

[TheOneRing]

Looks good so far. You renamed the in file but the installed file name is still correct?

[p-fruck]

@TheOneRing the resulting filename after cmake configure matches the app id which is correct, but I am not sure about the CMAKE_CURRENT_BINARY_DIR output folder. Any specific reason this was changed from KDE_INSTALL_METAINFODIR?

[CodedOre]

It would be recommended to add an description for releases as well.

This description will be shown in software managers such as GNOME Software, Bazaar or KDE Discover.

[p-fruck]

Honestly I don't like the idea of adding multiple lines of XML per release when the release details are linked already

[TheOneRing]

@TheOneRing the resulting filename after cmake configure matches the app id which is correct, but I am not sure about the CMAKE_CURRENT_BINARY_DIR output folder. Any specific reason this was changed from KDE_INSTALL_METAINFODIR?

The files are now generated at build time, the resulting file is now placed in CMAKE_CURRENT_BINARY_DIR before it is installed one line later.

[TheOneRing]

The branding in the desktop app is rather conservative.
Our official colours are:
Petrol:#20434F
Lilac: #E2BAFF

[TheOneRing]

One for a dark and a light theme, what colour is to be used here depends on whether its a highlight or a background or whatever.

[p-fruck]

thanks, I wasn't aware. The example shows #ff00ff for dark theme and #993d3d for light theme, hence I chose Lilac for light and petrol for dark correspondingly

[TheOneRing]

Besides the branding colour, what is the state of this pr?

[p-fruck]

@TheOneRing I just updated the branding colors and rebased this PR. From my point of view, we are ready to merge ^^

[TheOneRing]

Thanks!

[TheOneRing]

@p-fruck the kde appstream metadata test fails.

[p-fruck]

@TheOneRing interesting, appstream validate passed locally... Added the missing icon type, can we try again?

[TheOneRing]

Failed again, I assume the new ecm release made it more strict.

[p-fruck]

I'm confused.

I: eu.opencloud.desktop.beta.opencloud_beta:11: unknown-tag developer

E: eu.opencloud.desktop.beta.opencloud_beta:22: metainfo-invalid-icon-type
local

Local is the correct icon type if I am not mistaken? https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-icon

Also, developer is a valid tag, but this is not an error: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer

[TheOneRing]

For the developer tag, the version of appstreamcli might be too old.

For the image type, my ai says while its in the spec, you're not supposed to use it....
Would a remote url work here?

[p-fruck]

Sure, switched to remote in 1a2c895. Hopefully it works now

[TheOneRing]

I guess we should use a specific revision for the url. Else stuff will break one day so one moves the file around.

[p-fruck]

good point, permalinked to current main

[TheOneRing]

yay, thx