Remove duplicate agentic commerce authors - #2944
Conversation
|
Hi Kazuhiro, small follow-up PR to remove the duplicate author line from the published AgentCore Payments Cookbook page. CI is green and the diff is only three deletions. Could you take a quick look? PR #2944 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21816b2418
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert "responses_client.responses.create" in source | ||
| assert '"function_call_output"' in source | ||
| assert "**Authors:** Deepak Jain and Sid Rampally" in source | ||
| assert "AgentCore Runtime is not used by this notebook" in source |
There was a problem hiding this comment.
The publication contract now passes whether the notebook contains the duplicate author line or not, so it does not protect the rendering behavior this change is intended to establish. If the line is accidentally reintroduced, CI will not detect the regression; replace the removed positive assertion with a negative assertion for the same text.
Useful? React with 👍 / 👎.
1 participant
Summary
Why
The Cookbook page already renders Deepak Jain and Sid Rampally from registry metadata. The notebook repeated the same names at the start of the content.
Validation
env -u VIRTUAL_ENV uv run --with nbformat python .github/scripts/check_notebooks.pyenv -u VIRTUAL_ENV uv run --group dev pytest -q(142 passed)env -u VIRTUAL_ENV uv run --group dev ruff check src testsenv -u VIRTUAL_ENV uv run --group dev ruff format --check src testsgit diff --check