[codex] Treat Guardian capacity exhaustion as unavailable - #27540
Closed
kbazzi wants to merge 3 commits into
Closed
Conversation
kbazzi
force-pushed
the
codex/guardian-infrastructure-fallback-stacked
branch
from
June 11, 2026 04:27
bc227dd to
9a78cc2
Compare
kbazzi
force-pushed
the
codex/guardian-infrastructure-fallback-stacked
branch
from
June 11, 2026 04:38
9a78cc2 to
4b34064
Compare
This was referenced Jun 12, 2026
…llback' into codex/guardian-infrastructure-fallback-stacked # Conflicts: # codex-rs/core/tests/suite/guardian_review.rs
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Guardian review can fail before it produces a policy assessment. One concrete case is repeated selected-model-capacity /
server_is_overloadedresponses from the Guardian reviewer model.#27062 made structured transient Guardian session failures retryable, but after the retry budget was exhausted the terminal error still flowed through the generic fail-closed path. That path synthesizes a high-risk denial, so model capacity exhaustion could be reported as an Auto Review denial instead of Guardian unavailability.
That distinction matters for the timeout/manual-fallback behavior in #27440: exhausted transient infrastructure failures should be treated as unavailable or timed out, not as Guardian denying the action.
What Changed
ReviewDecision::TimedOut.Stack
Stacked on #27440. This PR is only about exhausted transient Guardian session failures such as model capacity. #27440 owns the opt-in
guardian_manual_approval_fallbackfeature flag, and #27537 is stacked above this PR for the separate remote-compact websocket reset classification issue.Validation
just test -p codex-core guardian_review_exhausted_model_capacity_failures_do_not_deny --no-captureenv -u CODEX_SANDBOX -u CODEX_SANDBOX_NETWORK_DISABLED just test -p codex-core guardian_capacity_exhaustion_falls_back_to_manual_approval_end_to_end --no-capturejust fix -p codex-core