feat: add auth-specific encrypted secret namespaces - #27535
Merged
Conversation
This was referenced Jun 11, 2026
celia-oai
marked this pull request as ready for review
June 11, 2026 04:38
celia-oai
changed the title
aibrahim-oai
approved these changes
Jun 11, 2026
aibrahim-oai
left a comment
aibrahim-oai
left a comment
Contributor
There was a problem hiding this comment.
approved with nits on naming
celia-oai
force-pushed
the
codex/secret-auth-storage-config
branch
from
June 12, 2026 18:53
683a9f4 to
3e3379b
Compare
celia-oai
force-pushed
the
codex/secret-auth-storage-namespaces
branch
from
June 12, 2026 18:58
53c24ac to
e026ff2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CLI auth and MCP OAuth credentials should use separate encrypted files while sharing the existing local-secrets implementation and OS-keyring-backed encryption key mechanism.
This is the second PR in the encrypted-auth stack:
What Changed
LocalSecretsNamespacevariants for shared secrets, CLI auth, and MCP OAuth.local.age,cli_auth.age, ormcp_oauth.agefrom the namespace.SecretsManagerconstruction and coverage proving the auth namespaces write separate encrypted files.This PR does not activate either auth backend or change existing credential behavior.
Validation
just test -p codex-secrets— 7 passedjust test -p codex-keyring-store— package has no test binariesjust fmt