[codex] Report unusable MCP OAuth credentials as logged out - #26713
Merged
Conversation
anp-oai
marked this pull request as ready for review
June 7, 2026 01:23
anp-oai
force-pushed
the
codex/expired-oauth-auth-status-regression
branch
from
June 7, 2026 01:23
75dd093 to
be77938
Compare
etraut-openai
approved these changes
Jun 9, 2026
etraut-openai
left a comment
Contributor
There was a problem hiding this comment.
Change looks good.
I built locally and had Codex do a manual test with a mock MCP server and tested four cases: auth valid, no auth, refresh succeeds, refresh fails. All of them worked as expected.
anp-oai
force-pushed
the
codex/expired-oauth-auth-status-regression
branch
from
June 9, 2026 20:50
be77938 to
f5101b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Persisted MCP OAuth credentials were reported as authenticated whenever a credential record existed. An expired token without a usable refresh token could therefore appear as
OAutheven though startup could not authenticate with it, leaving users with a misleading status instead of a login prompt.What changed
Validation
just test -p codex-rmcp-client