fix: normalize all JSDoc comments#335
Open
MattiasBuelens wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for custom-elements-manifest-analyzer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MattiasBuelens
changed the title
MattiasBuelens
added a commit
to THEOplayer/web-ui
that referenced
this pull request
Apr 28, 2026
Needs to be fixed in analyzer: open-wc/custom-elements-manifest#335
MattiasBuelens
added a commit
to THEOplayer/web-ui
that referenced
this pull request
Apr 28, 2026
Needs to be fixed in analyzer: open-wc/custom-elements-manifest#335
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any
JSDocTag's comment can hold either a plainstringor aNodeArray<JSDocComment>. We need to always normalize these to a plain string, otherwise the generated manifest would still contain references to TypeScript nodes and source files which cannot be serialized to JSON.