Update to OpenTelemetry Proto 0.4.0 - #889
Merged
Merged
Conversation
codeboten
suggested changes
Jul 9, 2020
codeboten
left a comment
codeboten
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this work! Would like to see handling of array_value and kvlist_value before approving, since that's part of the breaking changes in the 0.4.0 trace proto
Contributor
|
Updates look good, please add a changelog entry and i'll approve |
codeboten
approved these changes
Jul 9, 2020
Member
|
Could you update here with the That will regen everything including the stubs, as well and delete any old files if there are any. |
lzchen
approved these changes
Jul 13, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…y#889) * feat: start a root span with spanOptions.parent = null * chore: lint * chore: add return type for readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #886