Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/5297.changed
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
opentelemetry-sdk: update iterator for BoundedList
4 changes: 2 additions & 2 deletions opentelemetry-api/src/opentelemetry/attributes/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,9 @@ def __delitem__(self, key: str) -> None:
with self._lock:
del self._dict[key]

def __iter__(self): # type: ignore
def __iter__(self):
with self._lock:
return iter(list(self._dict)) # type: ignore
return iter(list(self._dict))

def __len__(self) -> int:
return len(self._dict)
Expand Down
24 changes: 24 additions & 0 deletions opentelemetry-sdk/benchmarks/trace/test_benchmark_trace.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,18 @@ def test_read_events(benchmark, num_events):
provider.add_span_processor(_EventsReadingProcessor())
tp = provider.get_tracer("bench")

peaks = []
for _ in range(200):
span = tp.start_span("benchmarkedSpan")
for event in range(num_events):
span.add_event(f"event{event}", {"k": "v"})
tracemalloc.start()
span.end()
_, peak = tracemalloc.get_traced_memory()
tracemalloc.stop()
peaks.append(peak)
benchmark.extra_info["mean_alloc_bytes"] = sum(peaks) / len(peaks)

def benchmark_read_events():
span = tp.start_span("benchmarkedSpan")
for event in range(num_events):
Expand All @@ -187,6 +199,18 @@ def test_read_links(benchmark, num_links):
provider.add_span_processor(_LinksReadingProcessor())
tp = provider.get_tracer("bench")

peaks = []
for _ in range(200):
span = tp.start_span("benchmarkedSpan")
for _ in range(num_links):
span.add_link(_link_context)
tracemalloc.start()
span.end()
_, peak = tracemalloc.get_traced_memory()
tracemalloc.stop()
peaks.append(peak)
benchmark.extra_info["mean_alloc_bytes"] = sum(peaks) / len(peaks)

def benchmark_read_links():
span = tp.start_span("benchmarkedSpan")
for _ in range(num_links):
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-sdk/src/opentelemetry/sdk/util/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def __len__(self):

def __iter__(self):
with self._lock:
return iter(deque(self._dq))
return iter(list(self._dq))

def append(self, item):
with self._lock:
Expand Down
Loading