sdk: Implement basic host resource detector - #4182
Conversation
pmcollins
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Added some comments.
Co-authored-by: Pablo Collins <pablo.collins@gmail.com>
|
@oliver-zhang please setup |
|
|
Do we want to add this ResourceDetector to the list of entry points here or were you thinking that would be for another PR? |
pmcollins
left a comment
There was a problem hiding this comment.
LGTM -- thanks for doing this. Left a comment about linting.
|
What should our guidance be for adding in resource detectors that have attributes that are not yet stable in the semantic conventions? Should we be including this as part of the sdk package? I know we might have (mistakenly) added the os resource detector as part of the sdk. Should we place these in contrib for now until sem convs are stable? |
|
I would be good with adding an underscore |
@lzchen It's done |
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
|
Looks like we are good to merge, no? There's a change requested but it looks like it has been addressed. cc @xrmx 🙏 |
Description
This PR will create a resource module in contrib repo which will fetch the host.name,host.arch properties
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: