Update ValueError message that is misleading

[howardyoo]

Description

The ValueError message is misleading that it does not include infinity as accepted value as interval. The message therefore needs to be changed as developers were getting confused.

Fixes #3768

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

The behavior can be seen when you try to set the reporting interval with Zero. However, setting the value as math.inf does work.

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

• The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

• The method interfaces of test/util have changed

• Scripts in scripts/ that were copied over to the Contrib repo have changed

• Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

  • pyproject.toml
  • isort.cfg
  • .flake8

• When a new .github/CODEOWNER is added

• Major changes to project information, such as in:

  • README.md
  • CONTRIBUTING.md

• Yes. - Link to PR:

• No.

Checklist:

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[howardyoo]

That makes total sense! I’ll update the PR. Very nice suggestion :-)Sent from my iPhoneOn Mar 11, 2024, at 11:31 AM, Tammy Baylis ***@***.***> wrote: @tammy-baylis-swi commented on this pull request. In opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py:

@@ -496,7 +496,7 @@ def __init__(

elif self._export_interval_millis <= 0: raise ValueError( f"interval value {self._export_interval_millis} is invalid \ - and needs to be larger than zero and lower than infinity." + and needs to be larger than zero and lower than or equal to infinity." Thank you putting in this PR to match actual behaviour and the Reader class docstring. I suggest we make the message simpler: ⬇️ Suggested change - and needs to be larger than zero and lower than or equal to infinity." + and needs to be larger than zero." —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[tammy-baylis-swi]

Thank you!

[lzchen]

@howardyoo

Please fix the conflicts and we can get this merged! Thanks!

[howardyoo]

@howardyoo

Please fix the conflicts and we can get this merged! Thanks!

I don't see any conflicts. What are you referring to?