Skip to content

Make entry_points behave the same across Python versions - #3168

Closed
ocelotl wants to merge 11 commits into
open-telemetry:mainfrom
ocelotl:issue_3167
Closed

Make entry_points behave the same across Python versions#3168
ocelotl wants to merge 11 commits into
open-telemetry:mainfrom
ocelotl:issue_3167

Conversation

@ocelotl

@ocelotl ocelotl commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

Fixes #3167

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 8, 2023
@ocelotl ocelotl self-assigned this Feb 8, 2023
@ocelotl
ocelotl requested a review from a team February 8, 2023 01:21
shalevr
shalevr reviewed Feb 8, 2023
View reviewed changes
Comment thread opentelemetry-api/tests/util/test__importlib_metadata.py
shalevr
shalevr reviewed Feb 8, 2023
View reviewed changes
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated
shalevr
shalevr reviewed Feb 8, 2023
View reviewed changes
Comment thread opentelemetry-api/tests/util/test__importlib_metadata.py Outdated
@ocelotl
ocelotl requested a review from shalevr February 9, 2023 04:07
@ocelotl ocelotl mentioned this pull request Feb 23, 2023
Closed
lzchen
lzchen reviewed Feb 23, 2023
View reviewed changes
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated
@lzchen

lzchen commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

I'm still not sure about the purpose of this change. Could you be more specific about the issue description or provide an example?

@ocelotl

ocelotl commented Feb 24, 2023

Copy link
Copy Markdown
Contributor Author

I'm still not sure about the purpose of this change. Could you be more specific about the issue description or provide an example?

@lzchen PTAL here.

@ocelotl ocelotl mentioned this pull request Feb 24, 2023
Merged
@ocelotl
ocelotl requested a review from lzchen February 24, 2023 23:53
lzchen
lzchen reviewed Feb 27, 2023
View reviewed changes
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated
lzchen
lzchen reviewed Feb 27, 2023
View reviewed changes
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated
lzchen
lzchen reviewed Feb 27, 2023
View reviewed changes
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated
lzchen
lzchen reviewed Feb 27, 2023
View reviewed changes
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated
lzchen
lzchen reviewed Feb 27, 2023
View reviewed changes
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated
lzchen
lzchen reviewed Feb 27, 2023
View reviewed changes
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py
lzchen
lzchen reviewed Feb 27, 2023
View reviewed changes
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py
lzchen
lzchen reviewed Feb 27, 2023
View reviewed changes
Comment thread opentelemetry-api/tests/util/test__importlib_metadata.py
lzchen
lzchen reviewed Feb 27, 2023
View reviewed changes
Comment thread opentelemetry-api/tests/util/test__importlib_metadata.py
lzchen
lzchen reviewed Feb 27, 2023
View reviewed changes
Comment thread opentelemetry-api/tests/util/test__importlib_metadata.py
@ocelotl
ocelotl requested a review from lzchen February 28, 2023 17:20
aabmass
aabmass reviewed Mar 6, 2023
View reviewed changes
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated
Comment thread opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated
@ocelotl
ocelotl force-pushed the issue_3167 branch 2 times, most recently from 001a70d to f3839c9 Compare March 13, 2023 23:22
@ocelotl
ocelotl requested a review from aabmass March 13, 2023 23:24
@ocelotl ocelotl mentioned this pull request Mar 14, 2023
Closed
7 tasks
@ocelotl

ocelotl commented Mar 14, 2023

Copy link
Copy Markdown
Contributor Author

May be overridden by #3217.

@lzchen lzchen mentioned this pull request Mar 15, 2023
Merged
@ocelotl

ocelotl commented Mar 16, 2023

Copy link
Copy Markdown
Contributor Author

Closing in favor of #3217

@ocelotl ocelotl closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzchen lzchen lzchen approved these changes
@shalevr shalevr Awaiting requested review from shalevr
@aabmass aabmass Awaiting requested review from aabmass

Assignees

@ocelotl ocelotl

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make entry_points behave the same across Python versions

5 participants

@ocelotl @lzchen @aabmass @shalevr @srikanthccv