Skip to content

Capture exception information in log attributes - #2531

Merged
lzchen merged 16 commits into
open-telemetry:mainfrom
lzchen:exc
Mar 21, 2022
Merged

Capture exception information in log attributes#2531
lzchen merged 16 commits into
open-telemetry:mainfrom
lzchen:exc

Conversation

@lzchen

@lzchen lzchen commented Mar 15, 2022

Copy link
Copy Markdown
Contributor

@lzchen
lzchen requested a review from a team March 15, 2022 18:00
lzchen
lzchen commented Mar 15, 2022
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/__init__.py Outdated
srikanthccv
srikanthccv reviewed Mar 16, 2022
View reviewed changes
Comment thread opentelemetry-sdk/tests/logs/test_handler.py Outdated
Comment thread opentelemetry-sdk/tests/logs/test_handler.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/__init__.py Outdated
ocelotl
ocelotl reviewed Mar 17, 2022
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/__init__.py Outdated
ocelotl
ocelotl reviewed Mar 17, 2022
View reviewed changes
Comment thread opentelemetry-sdk/tests/logs/test_handler.py Outdated
ocelotl
ocelotl reviewed Mar 17, 2022
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/__init__.py
ocelotl
ocelotl reviewed Mar 17, 2022
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/__init__.py Outdated
ocelotl
ocelotl reviewed Mar 17, 2022
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/__init__.py
ocelotl
ocelotl suggested changes Mar 17, 2022
View reviewed changes

@ocelotl ocelotl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be a couple bugs hidden in the implementation.

aabmass
aabmass reviewed Mar 18, 2022
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/__init__.py
aabmass
aabmass approved these changes Mar 18, 2022
View reviewed changes

@aabmass aabmass left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

codeboten
codeboten approved these changes Mar 18, 2022
View reviewed changes

@codeboten codeboten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @ocelotl please review and see if your changes have been addressed 👍

@srikanthccv
srikanthccv requested a review from ocelotl March 21, 2022 14:15
@lzchen
lzchen merged commit 97a36ea into open-telemetry:main Mar 21, 2022
@lzchen
lzchen deleted the exc branch March 21, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabmass aabmass aabmass approved these changes
+3 more reviewers
@srikanthccv srikanthccv srikanthccv left review comments
@codeboten codeboten codeboten approved these changes
@ocelotl ocelotl ocelotl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Record exception information in logging

5 participants

@lzchen @codeboten @aabmass @ocelotl @srikanthccv