Skip to content

Update bootstrap cmd to use exact version when installing instrumentation packages - #1722

Merged
lzchen merged 2 commits into
open-telemetry:mainfrom
owais:bootstrap-install-same-version-as-instrumentation
Apr 1, 2021
Merged

Update bootstrap cmd to use exact version when installing instrumentation packages#1722
lzchen merged 2 commits into
open-telemetry:mainfrom
owais:bootstrap-install-same-version-as-instrumentation

Conversation

@owais

@owais owais commented Mar 28, 2021

Copy link
Copy Markdown
Contributor

Description

This commit updates the bootstrap command to ensure it'll install
instrumentation packages compatible with the opentelemetry-instrument
package.

Since opentelemetry-instrumentation (as as a result all
instrumentations) are not stable yet, installing an instrumentation
package older or newer than opentelemtry-instrumentation can result in
a broken setup. This commit updates the bootstrap command so that it'll
always install instrumentation packages with the exact same version as
it's own.

This will only work as long as we keep releasing newer versions of all instrumentation packages in tandem with the opentelemetry-instrumentation package but I think we'll keep doing that until opentelemetry-instrumentation hits 1.0.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais
owais force-pushed the bootstrap-install-same-version-as-instrumentation branch 3 times, most recently from 45a01bb to 7656569 Compare March 29, 2021 00:06
instrumentation packages

This commit updates the bootstrap command to ensure it'll install
instrumentation packages compatible with the opentelemetry-instrument
package.

Since opentelemetry-instrumentation (as as a result all
instrumentations) are not stable yet, installing an instrumentation
package older or newer than opentelemtry-instrumentation can result in
a broken setup. This commit updates the bootstrap command so that it'll
always install instrumentation packages with the exact same version as
it's own.
@owais
owais force-pushed the bootstrap-install-same-version-as-instrumentation branch from 7656569 to 2e27f12 Compare March 29, 2021 00:12
@owais
owais marked this pull request as ready for review March 29, 2021 00:24
@owais
owais requested review from a team, codeboten and ocelotl and removed request for a team March 29, 2021 00:24
@lzchen

lzchen commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

This will only work as long as we keep releasing newer versions of all instrumentation packages in tandem with the opentelemetry-instrumentation package but I think we'll keep doing that until opentelemetry-instrumentation hits 1.0.

I think this will be easier as well once we move the openteleemtry-instrumentation package into the contrib repo. #1532

@codeboten codeboten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@lzchen
lzchen merged commit 58521be into open-telemetry:main Apr 1, 2021
@owais
owais deleted the bootstrap-install-same-version-as-instrumentation branch April 2, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants