Add Python 3.9 to build - #1441
Merged
Merged
Conversation
gliptak
requested review from
a team,
lzchen and
toumorokoshi
and removed request for
a team
December 2, 2020 19:34
|
|
codeboten
reviewed
Dec 3, 2020
codeboten
left a comment
codeboten
left a comment
Contributor
There was a problem hiding this comment.
This PR looks good, any idea why the checks didn't get run by github actions?
Contributor
Author
|
@codeboten which checks you are referring to? |
Contributor
|
I would expect the checks here to show py39 as well |
codeboten
reviewed
Dec 3, 2020
Contributor
Author
|
Failed single test looks unrelaed |
toumorokoshi
suggested changes
Dec 4, 2020
toumorokoshi
left a comment
toumorokoshi
left a comment
Member
There was a problem hiding this comment.
Thanks for the changes!
It looks like python3.8 is used as the primary version for linting and tracecontext in tox.ini. I think those should be bumped too.
Contributor
Author
|
@toumorokoshi as per pylint-dev/pylint#3882 |
toumorokoshi
approved these changes
Dec 10, 2020
toumorokoshi
left a comment
toumorokoshi
left a comment
Member
There was a problem hiding this comment.
LGTM! thanks for looking into the linting.
Contributor
|
@gliptak can you add an entry to the changelog for this? |
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
ocelotl
approved these changes
Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Python 3.9 to build