Sync with auto generated semantic convention constants - #428
Merged
Conversation
srikanthccv
marked this pull request as ready for review
April 10, 2021 13:52
srikanthccv
requested review from
a team,
hectorhdzg and
ocelotl
and removed request for
a team
April 10, 2021 13:52
srikanthccv
added
the
Skip Changelog
4 tasks
codeboten
approved these changes
Apr 19, 2021
codeboten
left a comment
codeboten
left a comment
Contributor
There was a problem hiding this comment.
🎉 🚀 Nice work, thanks for cleaning all this up. Only comment after reviewing is it would be nice to remove some of the duplication in our test code :D
lzchen
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync up with open-telemetry/opentelemetry-python#1759