fix(sdk-node): support headers_list for log exporters - #6955
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6955 +/- ##
=======================================
Coverage 95.02% 95.02%
=======================================
Files 409 409
Lines 14301 14301
Branches 3277 3277
=======================================
Hits 13590 13590
Misses 711 711
🚀 New features to boost your workflow:
|
Pull request dashboard statusClosed · refreshed 2026-08-12 20:08 UTC Status above doesn't look right?
|
Independent verificationI checked out rojo — src de main (636e27a) + test de la PR: no compila (la API no existe) (must fail without the fix) verde — src de la PR (55c168c): build + suite utils compilada 64/64 (must pass) — 3 runs, identical exit code Environment and output hashesFraming note: this is a feature PR, so there is no bug to reproduce — the honest "red" is that the new tests don't even compile against (Verification block produced with a local harness that records commands, exit codes and output hashes — all re-runnable from the steps above.) |
|
Hi @open-telemetry/javascript-approvers, this PR is ready for review. The current hosted checks are green, and the focused parser/header tests are documented in the PR body. Please let me know if any changes or additional validation would help. Thank you. |
Signed-off-by: Liang Hu <lh3057@columbia.edu>
Signed-off-by: Liang Hu <lh3057@columbia.edu>
55c168c to
2858a2f
Compare
…s-list-6953 # Conflicts: # experimental/packages/opentelemetry-sdk-node/src/create-from-config.ts
|
@LarryHu0217 my apologies for swallowing this work into my PR, I didn't see this originally. Please let me know if you'd like to take back over or if there's anything I can do to help you reviews or PRs wise to make up for it! |
Fixes #6953
Changes
headers_listvalues using the existing percent-decoding key/value parserheadersoverheaders_list, preserving the documented precedenceheaders_listas handled during exporter creationTesting
create-from-configandutilstests: 93 passinggit diff --check