fix(instrumentation-express): preserve matched route after handler - #3747
Open
Philipp-Perepelitsky wants to merge 1 commit into
Open
Conversation
Assisted-by: ChatGPT 5.6 Sol
|
|
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-js-contrib. Important reminders:
|
github-actions
Bot
requested review from
JamieDanielson,
pkanal and
raphael-theriault-swi
September 9, 2026 08:08
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-09 08:17 UTC Review the latest changes. Status above doesn't look right?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: ChatGPT 5.6 Sol
Which problem is this PR solving?
Fixes #2884.
Express middleware that runs after a matched request handler can overwrite RPCMetadata.route with a less specific middleware route. This can cause the HTTP server span to report an incorrect http.route.
Short description of the changes
-Preserve the route set by a request handler when later middleware executes.
-Continue allowing middleware to update route metadata before a request handler has matched.
-Add a regression test covering a /users/:id request handler followed by /users middleware.
Testing
-npm test -- --grep "rpcMetadata.route|should not overwrite route metadata" — 5 passing
-npm run compile — passing
-git diff --check — passing