Skip to content

Change play instrumentation name to play-mvc and restructure dirs - #6106

Merged
trask merged 4 commits into
open-telemetry:mainfrom
breedx-splk:restructure_play_dirs
Jun 2, 2022
Merged

Change play instrumentation name to play-mvc and restructure dirs#6106
trask merged 4 commits into
open-telemetry:mainfrom
breedx-splk:restructure_play_dirs

Conversation

@breedx-splk

Copy link
Copy Markdown
Contributor

This is part of #4952

play renamed to play-mvc, and play-2.4 to play-mvc-2.4 (and same for 2.6).

Final structure looks like:

play/
  +---- play-mvc/
  |         +----- play-mvc-2.4/
  |         +----- play-mvc-2.6/
  |
  +---- play-ws/
            +----- play-ws-common/
            +----- play-ws-1.0/
            +----- play-ws-2.0/
            +----- play-ws-2.1/

I didn't change the actual instrumentation name, though. I didn't think we'd want that (would impact users who have chosen to disable it?)

@breedx-splk
breedx-splk requested a review from a team May 27, 2022 18:35

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change the actual instrumentation name, though. I didn't think we'd want that (would impact users who have chosen to disable it?)

go ahead, we've still been changing the instrumentation names to match when we change the module names, and we doc it in the migration notes at the top of the release notes

@trask trask changed the title Restructure play instrumentation dirs. Change play instrumentation name to play-mvc and restructure dirs Jun 2, 2022
@trask

trask commented Jun 2, 2022

Copy link
Copy Markdown
Member

thx @breedx-splk!

@trask
trask merged commit ee90c7c into open-telemetry:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants