Resolve end strategy after WithSpan method instead of before. - #5756
Merged
Conversation
mateuszrzeszutek
approved these changes
Apr 6, 2022
trask
approved these changes
Apr 7, 2022
Comment on lines
+16
to
+17
| // Isolated test to use clean classloader because reactor instrumentation is applied on static | ||
| // initialization. |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…elemetry#5756) * WIP * Resolve end strategy after WithSpan method instead of before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End strategies may be registered as a result of classload, e.g. reactor strategy will only be registered after reactor is classloaded since we instrument static initializer. Luckily we can just move the resolution of end strategy to after the method when any classes would have been loaded, since the end strategy isn't needed until then.