Convert all logging statements from slf4j to jul - #5674
Conversation
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
I found reviewing a bit confusing in places where TransformSafeLogger is used since that api is now different from normal loggers, maybe worth sync'ing up that class.
| // org.slf4j.LoggerFactory.getLogger((Class)ExceptionLogger.class) | ||
| // .debug("exception in instrumentation", t); | ||
| // ExceptionLogger.logSuppressedError("exception in instrumentation", t); |
I simplified the API so that it looks the same as public void log(Level level, String message, Object[] args, Throwable error)The original |
|
|
||
| testing { | ||
| suites { | ||
| val testExceptionHandler by registering(JvmTestSuite::class) { |
There was a problem hiding this comment.
Yes, just the ExceptionHandlerTest - I moved it to a separate source directory, along with all its dependencies. I found that when I run ./gradlew :javaagent-tooling:check locally it was randomly failing on that test; probably because it interfered with other bytecode modifying tests in the test source root.
There was a problem hiding this comment.
oh yes, I missed that this is tied to directory name, thx!
* Convert all logging statements from slf4j to jul * code review comments * fix tests * Fix randomly failing test
3 participants
Closes #5077