Add JBoss java.util.logging support - #5498
Merged
Merged
Conversation
trask
marked this pull request as ready for review
March 4, 2022 02:30
anuraaga
approved these changes
Mar 4, 2022
mateuszrzeszutek
approved these changes
Mar 4, 2022
trask
added a commit
that referenced
this pull request
Apr 4, 2022
* initialize the package Signed-off-by: Cuichen Li <cuichli@cisco.com> * add jboss-logmanger 2.1 instrumentation Signed-off-by: Cuichen Li <cuichli@cisco.com> * rename the test Signed-off-by: Cuichen Li <cuichli@cisco.com> * clean comment Signed-off-by: Cuichen Li <cuichli@cisco.com> * Revert "Add JBoss java.util.logging support (#5498)" This reverts commit 8b26cef. * Remove extra directory * Remove old jboss log manager test * Ensure no cross interference * Change base version to 1.1 * fix styles Signed-off-by: Cuichen Li <cuichli@cisco.com> * run spotless apply Signed-off-by: Cuichen Li <cuichli@cisco.com> * fix codenarc Signed-off-by: Cuichen Li <cuichli@cisco.com> * change the package version and additional module name Signed-off-by: Cuichen Li <cuichli@cisco.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* initialize the package Signed-off-by: Cuichen Li <cuichli@cisco.com> * add jboss-logmanger 2.1 instrumentation Signed-off-by: Cuichen Li <cuichli@cisco.com> * rename the test Signed-off-by: Cuichen Li <cuichli@cisco.com> * clean comment Signed-off-by: Cuichen Li <cuichli@cisco.com> * Revert "Add JBoss java.util.logging support (open-telemetry#5498)" This reverts commit 8b26cef. * Remove extra directory * Remove old jboss log manager test * Ensure no cross interference * Change base version to 1.1 * fix styles Signed-off-by: Cuichen Li <cuichli@cisco.com> * run spotless apply Signed-off-by: Cuichen Li <cuichli@cisco.com> * fix codenarc Signed-off-by: Cuichen Li <cuichli@cisco.com> * change the package version and additional module name Signed-off-by: Cuichen Li <cuichli@cisco.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't upstream this part originally because the JBoss test I included was working both with and without the extra instrumentation, but found the problem, that I was running the test against JBoss Logging 1.0.0, and the extra instrumentation is only needed starting from 1.1.0.