Weak cache optimization - #5344
Merged
Merged
Conversation
anuraaga
approved these changes
Feb 11, 2022
| if (value != null) { | ||
| return value; | ||
| } | ||
| // Best we can do, we don't expect high contention with this implementation. Note, this |
Contributor
There was a problem hiding this comment.
Oof yeah stopped being true when stopped using caffeine
| resetLookupKey(lookupKey); | ||
| } | ||
| return previous == null | ||
| ? target.computeIfAbsent(new WeakKey<>(key, this), ignored -> mappingFunction.apply(key)) |
Contributor
There was a problem hiding this comment.
I thought this was impossible due to needing to pass the weak key to mapping function but the solution of using a capturing lambda was so simple!
trask
marked this pull request as ready for review
February 11, 2022 01:53
mateuszrzeszutek
approved these changes
Feb 11, 2022
laurit
approved these changes
Feb 11, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Member
Author
|
thx @danielqsj! can you open an issue for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.