Akka http server span names are always akka.request #3478 - #5150
Merged
Conversation
mcmho
commented
Jan 17, 2022
mcmho
commented
Contributor
- removed hardcoded span name "akka.request"
- implemented route() in AkkaHttpServerAttributesExtractor to provide a better span name
- retrofitted AkkaHttpServerInstrumentationTest.groovy
- removed hardcoded span name "akka.request" - implemented route() in AkkaHttpServerAttributesExtractor to provide a better span name - retrofitted AkkaHttpServerInstrumentationTest.groovy
- removed hardcoded span name "akka.request" and changed to "HTTP {METHOD}"
- retrofitted AkkaHttpServerInstrumentationTest.groovy
# Conflicts: # instrumentation/akka/akka-http-10.0/javaagent/src/test/groovy/AkkaHttpServerInstrumentationTest.groovy
- removed hardcoded span name "akka.request" and changed to "HTTP {METHOD}"
- retrofitted AkkaHttpServerInstrumentationTest.groovy
- removed hardcoded span name "akka.request" and changed to "HTTP {METHOD}"
- retrofitted AkkaHttpServerInstrumentationTest.groovy and related tests
trask
approved these changes
Jan 20, 2022
trask
left a comment
trask
left a comment
Member
There was a problem hiding this comment.
thx! can you update the PR description above?
laurit
approved these changes
Jan 20, 2022
mateuszrzeszutek
approved these changes
Jan 20, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
… (open-telemetry#5150) * Akka http server span names are always akka.request open-telemetry#3478 - removed hardcoded span name "akka.request" - implemented route() in AkkaHttpServerAttributesExtractor to provide a better span name - retrofitted AkkaHttpServerInstrumentationTest.groovy * Akka http server span names are always akka.request open-telemetry#3478 - removed hardcoded span name "akka.request" and changed to "HTTP {METHOD}" - retrofitted AkkaHttpServerInstrumentationTest.groovy * Akka http server span names are always akka.request open-telemetry#3478 - removed hardcoded span name "akka.request" and changed to "HTTP {METHOD}" - retrofitted AkkaHttpServerInstrumentationTest.groovy * Akka http server span names are always akka.request open-telemetry#3478 - removed hardcoded span name "akka.request" and changed to "HTTP {METHOD}" - retrofitted AkkaHttpServerInstrumentationTest.groovy and related tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.