Convert InstrumentationTestRunner from interface to abstract class - #5112
Merged
trask merged 1 commit intoJan 14, 2022
Merged
Conversation
mateuszrzeszutek
approved these changes
Jan 14, 2022
laurit
approved these changes
Jan 14, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am looking into enabling java lint on this repo like the other ones and one particularly hairy one was the
@SafeVarargson the default method in InstrumentationTestRunner. It can only be applied on a final method, which is impossible for interfaces. I figured there isn't a big advantage to using an interface since it's more of a "bag of logic" for only two implementations that we would ever write, and in fact it allowed me to share some more code between the two.