Instrumentation for rxjava3.1.1 - #4954
Conversation
trask
left a comment
There was a problem hiding this comment.
we finally got rid of our one "patch release" base version (log4j 2.13.2) only to get a new one 😢
| * | ||
| * <p>Instrumentation can be disabled by calling the {@link TracingAssembly#disable()} method. | ||
| */ | ||
| public final class TracingAssembly { |
There was a problem hiding this comment.
This class has exactly the same name & package as the 3.0 one - won't they conflict inside the agent?
There was a problem hiding this comment.
Thanks, renamed 3.1.1 classes.
I don't like it either. What alternatives do we have? The whole problem stems from rxjava moving |
|
ya, no worries, I think it's a lost cause trying too hard to limit our version splitting... |
* Instrumentation for rxjava3.1.1 * Move common test classes * spotless * move rxjava 3.1.1 classes to separate package
|
@trask will this change apply to |
|
@eugeniyk commenting on a 4 year PR is a sure way for your question to get ignored. If you believe you have found a bug then please open a new issue. Include a minimal application that reproduces the problem. |
Resolves #4023