Skip to content

Instrumentation for rxjava3.1.1 - #4954

Merged
trask merged 4 commits into
open-telemetry:mainfrom
laurit:rxjava3.1.1
Jan 4, 2022
Merged

Instrumentation for rxjava3.1.1#4954
trask merged 4 commits into
open-telemetry:mainfrom
laurit:rxjava3.1.1

Conversation

@laurit

@laurit laurit commented Dec 20, 2021

Copy link
Copy Markdown
Contributor

Resolves #4023

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we finally got rid of our one "patch release" base version (log4j 2.13.2) only to get a new one 😢

*
* <p>Instrumentation can be disabled by calling the {@link TracingAssembly#disable()} method.
*/
public final class TracingAssembly {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class has exactly the same name & package as the 3.0 one - won't they conflict inside the agent?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, renamed 3.1.1 classes.

@laurit

laurit commented Jan 4, 2022

Copy link
Copy Markdown
Contributor Author

we finally got rid of our one "patch release" base version (log4j 2.13.2) only to get a new one 😢

I don't like it either. What alternatives do we have? The whole problem stems from rxjava moving ConditionalSubscriber and QueueSubscription interfaces to a different package. For QueueSubscription we could use reflection to invoke requestFusion method. With ConditionalSubscriber it is more troublesome because we have TracingConditionalSubscriber extends BasicFuseableSubscriber where BasicFuseableSubscriber takes ConditionalSubscriber as constructor argument. I guess we could use a jdk proxy that implements the same interfaces as BasicFuseableSubscriber and copy all the code from TracingConditionalSubscriber and BasicFuseableSubscriber into proxies invocation handler.

@trask

trask commented Jan 4, 2022

Copy link
Copy Markdown
Member

ya, no worries, I think it's a lost cause trying too hard to limit our version splitting...

@trask
trask merged commit 97f1104 into open-telemetry:main Jan 4, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Instrumentation for rxjava3.1.1

* Move common test classes

* spotless

* move rxjava 3.1.1 classes to separate package
@laurit
laurit deleted the rxjava3.1.1 branch July 6, 2023 17:44
@eugeniyk

eugeniyk commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

@trask will this change apply to 3.1.6 and other higher than 3.1.1 versions automatically? The reason I'm asking is that after 1.32.0 -> 2.15.0 bump of javaagent, context stop being propagated for some reason

@laurit

laurit commented Jun 5, 2025

Copy link
Copy Markdown
Contributor Author

@eugeniyk commenting on a 4 year PR is a sure way for your question to get ignored. If you believe you have found a bug then please open a new issue. Include a minimal application that reproduces the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instrument RxJava 3.1.1+

6 participants