Remove gRPC dependency for export - #4674
Merged
Merged
Conversation
anuraaga
requested review from
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
November 19, 2021 07:55
Contributor
Author
|
Found there was 200K cruft leftover open-telemetry/opentelemetry-java#3918 Luckily the cruft doesn't also bring in Guava so rather than excluding now and removing exclusion later probably fine to lose the last few pounds next release. |
iNikem
approved these changes
Nov 19, 2021
trask
approved these changes
Nov 19, 2021
trask
left a comment
trask
left a comment
Member
There was a problem hiding this comment.
default artifact size 24402582 -> 15406177 😍
Comment on lines
-14
to
-17
| // IMPORTANT when updating otelVersion, make sure that grpcVersion below is >= the grpc version | ||
| // used by that otel version | ||
| val otelVersion = "1.9.0" | ||
| val grpcVersion = "1.41.0" |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
Before