More grpc events - #4098
Merged
Merged
Conversation
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
September 12, 2021 04:16
anuraaga
approved these changes
Sep 13, 2021
| @@ -125,32 +107,57 @@ public void onMessage(RESPONSE message) { | |||
| GrpcHelper.MESSAGE_ID, | |||
Contributor
There was a problem hiding this comment.
I was looking for the SENT and found it in this "unchanged code" :P
mateuszrzeszutek
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4089 (I will split out the good question about unary calls to a separate issue).
This PR does 3 things:
SENTtoRECEIVEDSENTevent on the grpc client spanSENTevent on the grpc server span(the diff looks worse than it is, because I moved a couple of nested classes inside of other nested classes due to needing to use the AtomicLongFieldUpdater from multiple places now)