Skip to content

Move instrumentation specific classes out of javaagent-instrumentatio… - #3604

Merged
trask merged 1 commit into
open-telemetry:mainfrom
mateuszrzeszutek:move-instrumentation-specific-classes-out-of-javaagent-instrumentation-api
Jul 27, 2021
Merged

Move instrumentation specific classes out of javaagent-instrumentatio…#3604
trask merged 1 commit into
open-telemetry:mainfrom
mateuszrzeszutek:move-instrumentation-specific-classes-out-of-javaagent-instrumentation-api

Conversation

@mateuszrzeszutek

Copy link
Copy Markdown
Member

…n-api

@mateuszrzeszutek
mateuszrzeszutek marked this pull request as draft July 16, 2021 16:07
@mateuszrzeszutek

mateuszrzeszutek commented Jul 16, 2021

Copy link
Copy Markdown
Member Author

Making it a draft for now - gradle doesn't see those bootstrap modules as unique and produces a broken javaagent jar.
Okay, it's fixed now

@mateuszrzeszutek
mateuszrzeszutek force-pushed the move-instrumentation-specific-classes-out-of-javaagent-instrumentation-api branch from d2e914b to 4669004 Compare July 27, 2021 08:48
@mateuszrzeszutek
mateuszrzeszutek marked this pull request as ready for review July 27, 2021 08:48

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@trask
trask merged commit ed9e1a0 into open-telemetry:main Jul 27, 2021
@mateuszrzeszutek
mateuszrzeszutek deleted the move-instrumentation-specific-classes-out-of-javaagent-instrumentation-api branch July 28, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants