Expose correct Context.current() in reactive-netty callbacks - #2850
Merged
trask merged 4 commits intoApr 29, 2021
Conversation
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
pavolloffay,
trask and
tylerbenson
as code owners
April 22, 2021 14:55
jkwatson
reviewed
Apr 22, 2021
trask
approved these changes
Apr 27, 2021
mateuszrzeszutek
force-pushed
the
reactor-netty-context
branch
from
April 29, 2021 06:43
1f267aa to
00080fc
Compare
schmikei
pushed a commit
to schmikei/opentelemetry-java-instrumentation
that referenced
this pull request
Apr 17, 2025
…etry#2850) * Define semantic conventions yaml for non-otlp conventions Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update semantic_conventions/trace/exporter/exporter.yaml Co-authored-by: Christian Neumüller <christian+github@neumueller.me> * Update semantic_conventions/scope/exporter/exporter.yaml Co-authored-by: Joao Grassi <joao@joaograssi.com> * Rename otel to otel_span Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Christian Neumüller <christian+github@neumueller.me> Co-authored-by: Joao Grassi <joao@joaograssi.com>
schmikei
pushed a commit
to schmikei/opentelemetry-java-instrumentation
that referenced
this pull request
Apr 17, 2025
…etry#2850) * Define semantic conventions yaml for non-otlp conventions Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update semantic_conventions/trace/exporter/exporter.yaml Co-authored-by: Christian Neumüller <christian+github@neumueller.me> * Update semantic_conventions/scope/exporter/exporter.yaml Co-authored-by: Joao Grassi <joao@joaograssi.com> * Rename otel to otel_span Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Christian Neumüller <christian+github@neumueller.me> Co-authored-by: Joao Grassi <joao@joaograssi.com>
schmikei
pushed a commit
to schmikei/opentelemetry-java-instrumentation
that referenced
this pull request
Apr 17, 2025
…etry#2850) * Define semantic conventions yaml for non-otlp conventions Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update semantic_conventions/trace/exporter/exporter.yaml Co-authored-by: Christian Neumüller <christian+github@neumueller.me> * Update semantic_conventions/scope/exporter/exporter.yaml Co-authored-by: Joao Grassi <joao@joaograssi.com> * Rename otel to otel_span Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Christian Neumüller <christian+github@neumueller.me> Co-authored-by: Joao Grassi <joao@joaograssi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And make sure to clean up channel attributes in netty 4.1 instrumentation.
doOnResolve,doAfterResolve,doOnResolveError,doOnConnectedanddoOnDisconnectedare not covered because they're called either too early or too late and getting any context from the connection in one of them is impossible.I think it closes #2776 - I've checked all HTTP clients that we instrument and that seemed "reactive" to me and none of them allow to set listeners like reactor-netty does (or none at all).