Add instrumentation for rocketmq - #2263
Merged
Merged
Conversation
addname
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
February 12, 2021 14:42
Closed
mateuszrzeszutek
left a comment
mateuszrzeszutek
left a comment
Member
There was a problem hiding this comment.
Hey, thanks for contributing! I've left a few comments, please take a look at them 🙏
Sorry for taking so long to review this PR, it somehow went under our radar 😞
Member
Author
|
I am also very grateful to @anuraaga and @mateuszrzeszutek . This is not only a very challenging thing, but also things that can learn a lot. I will always pay attention to the development of the opentelemery community.:smiley: |
mateuszrzeszutek
left a comment
mateuszrzeszutek
left a comment
Member
There was a problem hiding this comment.
Thanks! I've got just a few more minor comments, but other than that it looks really good 👍
Member
Author
|
muzzle (:instrumentation:kotlinx-coroutines:javaagent) failed, how to deal with it? |
Member
That looks like a random failure, I'll re-run these checks for you. |
Member
|
Thanks @addname! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add rocketmq support
Resolves #1916