Add shared messaging process topology#19268
Draft
trask wants to merge 3 commits into
Draft
Conversation
Pull request dashboard statusStatus last refreshed: 2026-07-21 20:05:34 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, report it with the result you expected. |
trask
force-pushed
the
messaging-v1-43-topology
branch
from
July 19, 2026 05:04
ff11314 to
338dab6
Compare
This was referenced Jul 19, 2026
trask
force-pushed
the
messaging-v1-43-topology
branch
from
July 19, 2026 20:20
338dab6 to
468e026
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds shared messaging process-span topology while preserving legacy receive behavior.
Changes:
- Preserves ambient parents, otherwise extracts producer context.
- Centralizes process instrumenter construction and producer links.
- Tests ambient-parent and producer-fallback behavior.
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
MessagingProcessContextCustomizer.java |
Selects ambient or producer context. |
MessagingProcessInstrumenterFactory.java |
Builds compatible process topology. |
MessagingProcessContextCustomizerTest.java |
Tests context selection. |
trask
force-pushed
the
messaging-v1-43-topology
branch
from
July 19, 2026 20:31
321d485 to
3e750e6
Compare
trask
force-pushed
the
messaging-v1-43-topology
branch
from
July 21, 2026 01:52
3e750e6 to
13e5678
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 31 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/internal/MessagingProcessInstrumenterFactory.java:29
- [General] In stable mode this link extractor always adds the propagated producer context before the customizer runs. When there is no valid ambient parent, the customizer then selects that same producer context as the span parent, so the resulting process span records its parent again as a link. Add the producer as a link only when an ambient parent is actually retained (and the contexts differ), and cover the stable/no-ambient case in the factory test.
builder.addSpanLinksExtractor(new PropagatorBasedSpanLinksExtractor<>(propagator, getter));
trask
force-pushed
the
messaging-v1-43-topology
branch
from
July 21, 2026 04:15
13e5678 to
1632d29
Compare
trask
force-pushed
the
messaging-v1-43-topology
branch
from
July 21, 2026 05:04
46d230b to
e001fa6
Compare
trask
force-pushed
the
messaging-v1-43-topology
branch
from
July 21, 2026 05:15
e001fa6 to
582a12e
Compare
trask
force-pushed
the
messaging-v1-43-topology
branch
2 times, most recently
from
July 21, 2026 05:36
c55a4fb to
02ef2b3
Compare
trask
force-pushed
the
messaging-v1-43-topology
branch
from
July 21, 2026 06:30
02ef2b3 to
0c903bd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 31 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/internal/MessagingProcessInstrumenterFactory.java:39
- [General]
SpanContext.equals()also compares properties such as the remote flag, so a local ambient parent and the context extracted from itstraceparenthave the same span identity but are not equal. This then adds the parent span itself as a link, contrary to the intended parent-equal link suppression. Compare trace/span IDs instead, and cover the local-parent case in the regression test.
&& (!producerSpanContext.getTraceId().equals(parentSpanContext.getTraceId())
trask
force-pushed
the
messaging-v1-43-topology
branch
from
July 21, 2026 06:38
0c903bd to
dc68fa8
Compare
trask
force-pushed
the
messaging-v1-43-topology
branch
from
July 21, 2026 06:56
dc68fa8 to
a08723a
Compare
trask
force-pushed
the
messaging-v1-43-topology
branch
from
July 21, 2026 07:01
a08723a to
b41153e
Compare
trask
force-pushed
the
messaging-v1-43-topology
branch
from
July 21, 2026 17:42
b41153e to
9b5ec57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #19267.
Dependency baseline:
71cd7a78a22054d7e337169311c2d60c48b52c6d.Review only:
71cd7a78a22054d7e337169311c2d60c48b52c6d..9b5ec57607668f417ce57a15c2281897fcb3f774.Exactly one topology commit. Stable process spans avoid parent-equal links by IDs, preserve the original ambient Span object, and retain propagated non-span context.
Validated across default/stable/dual modes plus the full
instrumentation-api-incubator:checklifecycle.