Merge to main: New design for TelemetryHttpModule using ActivitySource + OpenTelemetry.API - #2270
Merged
Merged
Conversation
…ry.API part 2 (#2254) * Use a single context.Items key for state management to make things more efficient. * Added a comment for clarity. * Code review.
…ry.API part 3 (#2256) * Update ASP.NET instrumentation to use the new TelemetryHttpModule. * Fixed TelemetryHttpModule not starting its Activity objects. Added an example of request suppression. * Tweaks an logging improvements. * Sealed AspNetInstrumentationEventSource. * Code review.
…ry.API part 4 (#2258) * Fixed up TelemetryHttpModule unit tests. * Added tests for the new HasStarted helper and added checks for StartedButNotSampledObj when not sampled. * Code review.
…ry.API part 5 (#2261) * Updated ASP.NET instrumentation tests for new TelemetryHttpModule. * Added a test for the new RecordException option. * Code review.
…ry.API part 6 (#2264) * CHANGELOG & README updates. * Apply suggestions from code review Co-authored-by: Reiley Yang <reyang@microsoft.com> Co-authored-by: Reiley Yang <reyang@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #2270 +/- ##
==========================================
+ Coverage 79.25% 79.59% +0.34%
==========================================
Files 238 232 -6
Lines 7499 7284 -215
==========================================
- Hits 5943 5798 -145
+ Misses 1556 1486 -70
|
reyang
approved these changes
Aug 22, 2021
reyang
left a comment
reyang
left a comment
Member
There was a problem hiding this comment.
LGTM, consider merge the commits (do not squash).
cijothomas
approved these changes
Aug 24, 2021
Member
Author
|
@reyang I'm going to squash merge just because the commits only say "New design for TelemetryHttpModule using ActivitySource + OpenTelemetry.API part X" where X is 1-6. It's not really useful info. Probably should have preserved the commits into the working branch and then we could have done it here. Sorry about that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #2222
Relates to #2249
Closes #1701
Changes
Merges the new design for TelemetryHttpModule using ActivitySource + OpenTelemetry.API to main. Includes RecordException option in ASP.NET instrumentation.
TODOs
CHANGELOG.mdupdated for non-trivial changes